-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 04/24/2015 10:11 AM, Morgan Fainberg wrote:
> This is really an important reason why -1 with a question cannot > be simply "not done". If I don't understand the code, or what will > happen in a specific case, a -1 is more useful than a no score. > Complex code (or really clever code) is hard to maintain. +1 for giving a -1 :) If I don't understand the part of the code that is being patched, I don't review it. But if I do know that part of the code and I can't figure out what the thinking behind the patch is, I belive that a -1 is the appropriate response. I would certainly expect that for any unclear patches I submitted. The flip side of this, of course, is if I -1 something, I fully intend to follow up on the patch, and if it is clarified, remove the -1. The bigger problem is the hit-and-run approach of -1'ing a patch and then never returning. - -- - -- Ed Leafe -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: GPGTools - https://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCgAGBQJVOmE5AAoJEKMgtcocwZqLQXkQAKCaFJ0u4/RvPMPj5n1OCsoZ vx3lqGshJa2aHGhiX20e9EFIBDzSTPuM06ZJdsKWsRskdK3U/is2pHP7st/PrRUu okMUOodti8bA4ju2PNxXOKLioKakQghQf7I8E3b531m4Vx4+x7OBRHXYfe1YT8lL asOoba9GzkGoOqqGgfI4x2wRjU63kic3dqUTtEA1ResAnX5xZYxXWj0YHS3F6N12 kmLNBDbqB9BRvF9eBVOeIKqNRQ67/D0TmnJx4zze8lJnoI8Pi2BHmQIPcnS7tv1n jSgB6LUGh09tJ/jVyhHlFTZfnYaG4UDzOw1P7B/TNIv8yIpHZruii5NfYzGolbom 4/ZKwFMGHgvGEKoV9s/8E4TteebsQaYAYwwPrjvTdaJd67nflOJ8tdHWLhiNehLx urhPSyzAj5lwp51r2qTCEeRoaU7l5Pjl8Sq3LSpo3FX9aFb6tLrR9oSfju6gMeBC 7UiRAYo4uXLw2GHZ5/SmoECspG0WWOD+kPKayBykknX3d1mBXkmJxBfFAADPDWv3 ymahhN1DECiKwXn8lQn3YLGqduUxPJKMhjGZLh7iIVknYHDze2CTp88VM7kxO1w/ 9vyCcwvpnR7ahSE1lLkIVYHQ6HiyxD7jIP99tLx9Qfv3dKo4L0vtszcizAbJluHt izUfXSL4t0+oPRiKbcxY =eSbr -----END PGP SIGNATURE----- __________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
