Hi, Not approved.
Unfortunately it seems like dangerous patch, API changing and Liberty client will not support it as well. Let's have it merged early in M cycle (after Liberty RC published, master will be open for M). Thanks. On Fri, Sep 11, 2015 at 12:06 AM, Ethan Gafford <egaff...@redhat.com> wrote: > Sadly, in reviewing the client code, Vitaly is right; the current client > will not support this feature, which would make it direct REST call only. > Given that, I am uncertain it is worth the risk. I'd really love to have > seen this go in; it's a great feature and a lot of work has gone into it, > but perhaps it should be a great feature in M. > > If we agree to cut a new client point release, I could see this, but for > now I fear I'm -1. > > Thanks, > Ethan > > >From: "lu jander" <juvenboy1...@gmail.com> > >To: "OpenStack Development Mailing List (not for usage questions)" < > openstack-dev@lists.openstack.org> > >Sent: Monday, September 7, 2015 1:26:49 PM > >Subject: Re: [openstack-dev] [sahara] FFE request for scheduler and > suspend EDP job for sahara > > > > >Hi Vitaly, > >enable-scheduled-edp-jobs patch has 34 patch sets review. > https://review.openstack.org/#/c/182310/ , it has no impact with another > working in process patch. > > > >2015-09-07 18:48 GMT+08:00 Vitaly Gridnev <vgrid...@mirantis.com>: > > > > Hey! > > > > From my point of view, we definetly should not give FFE for > add-suspend-resume-ability-for-edp-jobs spec, because client side for this > change is not included in official liberty release. > > > > By the way, I am not sure about FFE for enable-scheduled-edp-jobs, > because it's not clear which progress of these blueprint. Implementation of > that consists with 2 patch-sets, and one of that marked as Work In Progress. > > > > > > On Sun, Sep 6, 2015 at 7:18 PM, lu jander <juvenboy1...@gmail.com> > wrote: > > > > Hi, Guys > > > > I would like to request FFE for scheduler EDP job and suspend > EDP job for sahara. these patches has been reviewed for a long time with > lots of patch sets. > > > > Blueprint: > > > > (1) > https://blueprints.launchpad.net/sahara/+spec/enable-scheduled-edp-jobs > > (2) > https://blueprints.launchpad.net/sahara/+spec/add-suspend-resume-ability-for-edp-jobs > > > > Spec: > > > > (1) https://review.openstack.org/#/c/175719/ > > (2) https://review.openstack.org/#/c/198264/ > > > > > > Patch: > > > > (1) https://review.openstack.org/#/c/182310/ > > (2) https://review.openstack.org/#/c/201448/ > > > > > __________________________________________________________________________ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > > > > > > -- > > Best Regards, > > Vitaly Gridnev > > Mirantis, Inc > > > > > __________________________________________________________________________ > > OpenStack Development Mailing List (not for usage questions) > > Unsubscribe: > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > >__________________________________________________________________________ > >OpenStack Development Mailing List (not for usage questions) > >Unsubscribe: > openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > >http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > -- Sincerely yours, Sergey Lukjanov Sahara Technical Lead (OpenStack Data Processing) Principal Software Engineer Mirantis Inc.
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev