Lost in the code...It seems the datasource just construct the entities and send them over event bus to entity graph processor. I need to dig further to find out the exact point the "backup" relationship is filtered.
I think we should some how keep the validation of relationship type. It is so easy to make typo when creating the template manually (I did this quite often...). My idea is to delegate the validation to datasource instead of enumerating all constants it in evaluator. I think this will introduce better extensibility. Any comments? On Thu, Aug 25, 2016 at 1:32 PM Weyl, Alexey (Nokia - IL) < alexey.w...@nokia.com> wrote: > Hi Yujun, > > > > You can find the names of the lables in the constants.py file. > > > > In addition, the restriction on the physical_static datasource is done in > it’s driver.py. > > > > Alexey > > > > *From:* Yujun Zhang [mailto:zhangyujun+...@gmail.com] > *Sent:* Thursday, August 25, 2016 4:50 AM > *To:* OpenStack Development Mailing List (not for usage questions) > *Subject:* Re: [openstack-dev] [vitrage] relationship_type in > static_datasources > > > > Hi, Ifat, > > > > I searched for edge_labels in the project. It seems it is validated only > in `vitrage/evaluator/template_validation/template_syntax_validator.py`. > Where is such restriction applied in static_datasources? > > > > -- > > Yujun > > > > On Wed, Aug 24, 2016 at 3:19 PM Afek, Ifat (Nokia - IL) < > ifat.a...@nokia.com> wrote: > > Hi Yujun, > > > > Indeed, we have some restrictions on the relationship types that can be > used in the static datasources. I think we should remove these > restrictions, and allow any kind of relationship type. > > > > Best regards, > > Ifat. > > > > *From: *Yujun Zhang > *Date: *Monday, 22 August 2016 at 08:37 > > I'm following the sample configuration in docs [1] to verify how static > datasources works. > > > > It seems `backup` relationship is not displayed in the entity graph view > and neither is it included in topology show. > > > > There is an enumeration for edge labels [2]. Should relationship in static > datasource be limited to it? > > > > [1] > https://github.com/openstack/vitrage/blob/master/doc/source/static-physical-config.rst > > [2] > https://github.com/openstack/vitrage/blob/master/vitrage/common/constants.py#L49 > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
