On 10/1/2016 9:48 AM, Akihiro Motoki wrote:
Hi,

I noticed strings in tests (unit tests or others) have translation marks
(_, _LE and so on).
Do we need translation marks for them?

I don't think so for most cases from various reasons below.
Only exception is to test translations.

From translators:
- Effort to translate strings in tests leads is meaningless. Such
translations are never used.
- Strings from test code drop the translation percentage.
  The current translation import script checks the translation percentage
  and imports translations with >75% percentage.

From developers:
- Translation mark is actually unnecessary but developers are requested
  to mark them as translatable. It is annoying.

Thought?

Thanks,
Akihiro



__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


No you shouldn't need to mark strings for translation in test code. I believe we have a hacking rule for marking LOG.info/warning/error messages for translation but it should skip test directories.

--

Thanks,

Matt Riedemann


__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Reply via email to