To the original poster: Can you file an issue about this and mail me its number? It's a reasonable fix that makes life easier, even if it's socially unacceptable and apparently gives stomach cramps to inheritance-hating purists ;)
Jason Carreira said: > Whatever your feelings about Inheritance, and I'm not a big fan of > implementation inheritance, there are some cases where it's REALLY not a > good idea.... Especially where the base class is not designed for nor > expecting subclassing... DefaultActionFactory is one of those and > changes to it would very likely break subclasses in rather > indeterministic ways (interactions between ActionFactory types was > always kind of tricky... If I remember, there's one of them in the stack > twice for some reason, but it has to be there like that) > >> -----Original Message----- >> From: Darryl Pentz [mailto:[EMAIL PROTECTED] >> Sent: Wednesday, September 17, 2003 9:27 AM >> To: [EMAIL PROTECTED] >> Subject: [OS-webwork] Re: Re: WW1's DefaultActionFactory >> >> >> You're right... I've ripped all the chapters on inheritance >> out of my OO books... bad, bad.... evil inheritance! >> >> ;) >> >> "Jason Carreira" <[EMAIL PROTECTED]> wrote in message >> news:<[EMAIL PROTECTED]>... Well, >> I guess I would say that's not a good idea on general >> principle. It suffers from the "fragile base class" problem >> where if we decided to change the DefaultActionFactory, it >> might break the special stuff you're doing in your subclass. >> >> > -----Original Message----- >> > From: Darryl Pentz [mailto:[EMAIL PROTECTED] >> > Sent: Wednesday, September 17, 2003 8:41 AM >> > To: [EMAIL PROTECTED] >> > Subject: [OS-webwork] Re: WW1's DefaultActionFactory >> > >> > >> > Right, which is what I'm doing. But I'm having to copy and >> paste the >> > Proxy chain from DefaultActionFactory. >> > >> > I was thinking it'd be nice to be able to simply extend >> > DefaultActionFactory and append my additional proxies on to >> the end of >> > the existing chain. >> > >> > I'd also pick up any changes/additions to that chain in >> > DefaultActionFactory automatically in the core code with >> WW1 upgrades >> > (not that there'll be any). >> > >> > No biggie, was just wondering. I guess the response to all >> this is... >> > upgrade to WW2! ;) >> > >> > "Jason Carreira" <[EMAIL PROTECTED]> wrote in message >> news:<[EMAIL PROTECTED]>... You >> can create your own ActionFactory and specify your class in the >> webwork.properties >> > >> > > -----Original Message----- >> > > From: Darryl Pentz [mailto:[EMAIL PROTECTED] >> > > Sent: Wednesday, September 17, 2003 6:33 AM >> > > To: [EMAIL PROTECTED] >> > > Subject: [OS-webwork] WW1's DefaultActionFactory >> > > >> > > >> > > It's a pity that WW1's DefaultActionFactory "factory" >> attribute is >> > > package protected and not class protected... it'd be useful >> > to extend >> > > DefaultActionFactory and just append some additional >> proxies to the >> > > default chain. Or am I missing some basic way of >> accomplishing that? >> > > >> > > This is where the WW2 IoC stuff comes in handy. >> > > >> > > - Darryl >> > > >> > > >> > > >> > > >> > > >> > > ------------------------------------------------------- >> > > This sf.net email is sponsored by:ThinkGeek >> > > Welcome to geek heaven. >> > > http://thinkgeek.com/sf >> > > _______________________________________________ >> > > Opensymphony-webwork mailing list >> > > [EMAIL PROTECTED] >> > > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork >> > > >> > >> > >> > ------------------------------------------------------- >> > This sf.net email is sponsored by:ThinkGeek >> > Welcome to geek heaven. >> > http://thinkgeek.com/sf >> > ---------- >> > >> > >> > >> > ------------------------------------------------------- >> > This sf.net email is sponsored by:ThinkGeek >> > Welcome to geek heaven. >> > http://thinkgeek.com/sf >> > _______________________________________________ >> > Opensymphony-webwork mailing list >> > [EMAIL PROTECTED] >> > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork >> > >> >> >> ------------------------------------------------------- >> This sf.net email is sponsored by:ThinkGeek >> Welcome to geek heaven. >> http://thinkgeek.com/sf >> ---------- >> >> >> >> ------------------------------------------------------- >> This sf.net email is sponsored by:ThinkGeek >> Welcome to geek heaven. >> http://thinkgeek.com/sf >> _______________________________________________ >> Opensymphony-webwork mailing list >> [EMAIL PROTECTED] >> https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork >> > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Opensymphony-webwork mailing list > [EMAIL PROTECTED] > https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Opensymphony-webwork mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/opensymphony-webwork
