Hi Carsten,
On Dienstag, 29. April 2008, Carsten Koch-Mauthe wrote:
> Now i've found why. There is some code in the openvasclient which will show
> the ssh creds only if the script name is "SSH settings"
> ===
> openvas-client/nessus/prefs_dialog/prefs_dialog_plugins_prefs.c: if (
> strcmp(plugin_name, "SSH settings") == 0 )
> ===
> So this script can not work, it is named "SSH Authorization".
> How to fix ? Change the client or change the script ?
> I've right now changed the script to work again for me.
> I've changed the following:
>
> name["english"] = "SSH settings";
this broken design is inherited from Nessus.
Here is my proposal how to improve it, at least slightly:
- Introduce a family "Credentials" and set it in the the respective
nasl scripts.
- Change prefs_dialog_plugins_prefs.c (is_credentials) to add return
true for this family instead of the current name-based heuristics.
- Change the "Credentials" page of OpenVAS-Client to work
in the same way as the Preferences page, ie. have a overview
and allow the user to click on the respective credentials name
to change the values.
This is basically intended to have a more consistent user interface.
Effects:
For some time, until new openvas-plugins and new OpenVAS-Client
have landed everywhere, the credentials may not appear in the credentials
page but only in the preferences page. Thus, the new openvas-pugins module
should be released prior to the new OpenVAS-Client.
What do you think?
Should I turn this into a Change Request?
Best
Jan
--
Dr. Jan-Oliver Wagner Intevation GmbH, Osnabrück
Amtsgericht Osnabrück, HR B 18998 http://www.intevation.de/
Geschäftsführer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner
_______________________________________________
Openvas-plugins mailing list
[email protected]
http://lists.wald.intevation.org/mailman/listinfo/openvas-plugins
