Hallo Jan, Am Mittwoch 30 April 2008 schrieb Jan-Oliver Wagner:
> On Dienstag, 29. April 2008, Carsten Koch-Mauthe wrote: > > Now i've found why. There is some code in the openvasclient which will > > show the ssh creds only if the script name is "SSH settings" === > > openvas-client/nessus/prefs_dialog/prefs_dialog_plugins_prefs.c: if ( > > strcmp(plugin_name, "SSH settings") == 0 ) === > > So this script can not work, it is named "SSH Authorization". > > How to fix ? Change the client or change the script ? > > I've right now changed the script to work again for me. > > I've changed the following: > > > > name["english"] = "SSH settings"; > > this broken design is inherited from Nessus. > > Here is my proposal how to improve it, at least slightly: > > - Introduce a family "Credentials" and set it in the the respective > nasl scripts. > > - Change prefs_dialog_plugins_prefs.c (is_credentials) to add return > true for this family instead of the current name-based heuristics. > > - Change the "Credentials" page of OpenVAS-Client to work > in the same way as the Preferences page, ie. have a overview > and allow the user to click on the respective credentials name > to change the values. > This is basically intended to have a more consistent user interface. > > Effects: > For some time, until new openvas-plugins and new OpenVAS-Client > have landed everywhere, the credentials may not appear in the credentials > page but only in the preferences page. Thus, the new openvas-pugins module > should be released prior to the new OpenVAS-Client. > > > What do you think? > Should I turn this into a Change Request? It was my mistake, that i've not found the creds in the Prefs page. I've not expected the ssh settings there. So it seems to be a very good idear to bring up all Credentials to the Credentials Page in that manner you proposed. -- Gruss Carsten Koch-Mauthe http://www.dn-systems.de mail: [EMAIL PROTECTED] DN-Systems Enterprise Internet Solutions GmbH Hornemannstr. 11 31137 Hildesheim, Germany Tel. +49-5121-28989-0 Fax. +49-5121-28989-11 21 Sunrise Ct, S.San Francisco, CA 94080, USA Tel. +1-650-472-2512 Mob. +1-650-430-1219 Handelsregister HRB-3213 Amtsgericht Hildesheim Geschäftsführer Lukas Grunwald _______________________________________________ Openvas-plugins mailing list [email protected] http://lists.wald.intevation.org/mailman/listinfo/openvas-plugins
