Updates to these scripts have now been committed, Thanks for pointing that out.
Thomas MadHat Unspecific wrote: > Also, at least 3 plugins (subversion_1_0_5.nasl, subversion_1_0_6.nasl, > subversion_1_0_8.nasl) require subversion_detect.nasl, so someone may > want to update those to require find_services2.nasl instead. > > Thomas Reinke wrote: >> Blech...me and my typos. The file IS committed. >> >> Please check find_service2.nasl, which already >> does what you are proposing. >> >> Thomas >> >> Thomas Reinke wrote: >>> Couple notes, >>> >>> If you do make a script that checks for a new type of service, >>> the script itself should make a call to register_service, >>> >>> e.g. register_service(port:port, proto:"subversion"); >>> >>> In this case, there seems to be some GPLed missing scripts >>> that already do what you've done. Specifically, >>> find_service2.nasl was definitely in the GPL feed, was >>> labelled as GPL post feed changes by Tenable, and afaict >>> should be in OpenVAS. >>> >>> Anyone know why this plugin wasn't committed? >>> >>> Thomas >>> >>> MadHat Unspecific wrote: >>>> Just randomly choosing a plugin to rewrite, here is what I came up >>>> with. >>>> Nothing here was taking from the Tenable plugin. I left the ID blank >>>> as I didn't know if it should be a new ID or use the Tenable >>>> subversion_detect ID (not what I would expect). I did some basic >>>> testing, but please let me know if this does not work. >>>> >>>> Thanks >>>> > > _______________________________________________ Openvas-plugins mailing list [email protected] http://lists.wald.intevation.org/mailman/listinfo/openvas-plugins
