Vlatko Kosturjak wrote:
> MadHat Unspecific wrote:
>> Just randomly choosing a plugin to rewrite, here is what I came up with.
>
> Thanks for your contribution!
>
>> Nothing here was taking from the Tenable plugin. I left the ID blank
>> as I didn't know if it should be a new ID or use the Tenable
>> subversion_detect ID (not what I would expect). I did some basic
>> testing, but please let me know if this does not work.
>
> Just send script with blank ID and I'll take it and put in 8NNNN
> contributions tree.
>
> Next time when you contribute script, please specify which version of
> GPL (GPL v2 or later or something else).
I really don't care. I am not intimately familiar with the differences
in the 2 and to me it is a moot point. Set it to the same thing OpenVAS
is using and move on.
>
> As other said, it seems your subversion detection is already implemented
> in find_service2.nasl. I just checked that service detection in
> find_service2.nasl and it seems it doesn't work in all cases as well as
> your script. I tried against my friend's SVN and this is what that SVN
> spits out:
> $ nc svn.rot13.org 3690
> ( success ( 2 2 ( ) ( edit-pipeline svndiff1 absent-entries
> commit-revprops depth log-revprops partial-replay ) ) )
>
> So, I changed line to (in find_service2.nasl):
> if (r=~ '^\\( success \\( [0-9] [0-9] \\(.*\\) \\(.*')
>
> Is there anyone who is willing to test against their Subversion
> installations?
I was going to point that out. The 2 digits will not always be 1 and 2,
but I am not sure the exact specs in subversion.
--
MadHat (at) Unspecific.com
"The true man wants two things: danger and play.
For that reason he wants woman, as the most dangerous plaything."
- Friedrich Nietzsche
_______________________________________________
Openvas-plugins mailing list
[email protected]
http://lists.wald.intevation.org/mailman/listinfo/openvas-plugins
