Takashi Iwai wrote:
> At Wed, 08 Jun 2005 19:40:38 +0800,
> Raymond wrote:
>
>>
>>typedef struct {
>> unsigned int *this00; /*CAsp4HwIO */
>> long this04; /* How many filters for each side (default =
>> 10) */
>> long this08; /* inited to cero. Stereo flag? */
>>} eqhw_t;
>>
>>static void vortex_EqHw_SetLevels(vortex_t * vortex, u16 peaks[])
>>{
>> eqhw_t *eqhw = &(vortex->eq.this04);
>> int i;
>>
>> /* set left peaks */
>> for (i = 0; i < eqhw->this04; i++) {
>> hwwrite(vortex->mmio, 0x2b024 + i * VORTEX_BAND_COEFF_SIZE,
>> peaks[i]);
>> }
>>
>> hwwrite(vortex->mmio, 0x2b3cc, peaks[eqhw->this04]);
>> hwwrite(vortex->mmio, 0x2b3d8, peaks[eqhw->this04 + 1]);
>>
>> /* set right peaks */
>> for (i = 0; i < eqhw->this04; i++) {
>> hwwrite(vortex->mmio, 0x2b204 + i * VORTEX_BAND_COEFF_SIZE,
>> peaks[i + (eqhw->this04 + 2)]);
>> }
>>
>> hwwrite(vortex->mmio, 0x2b3e4, peaks[2 + (eqhw->this04 * 2)]);
>> hwwrite(vortex->mmio, 0x2b3f0, peaks[3 + (eqhw->this04 * 2)]);
>>}
>>
>>
>> vortex_EqHw_SetLevels(vortex, (u16 *) eq_levels);
>>
>>
>>
>>
>>What is the reason to increase the size of the array eq_levels from 32
>>to 64 ? ( eqhw->this04 seem to be 10 )
>
>
> I guess he wants to keep the total array size just to be sure.
> But it seems not necessary.
Exactly for that purpose. I do not know if other (au8810 or au8830) use more
than au8820 in that array.
> (Oh, and the cast above is evil. Let's remove it.)
>
> Above all, any chance to rename the mysterious this* fields to more
> understandable ones?
>
I believe original author can tell us more :) Actually that this04 seems to
be not needed at all (I preferred to keep all struct sizes the same in 64bit
to not bother with hardware formats etc.)
--
Kind regards,
Igor V. Kovalenko
_______________________________________________
Openvortex-dev mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/openvortex-dev
