On Wed, Mar 28, 2012 at 9:57 AM, Fabian Knittel <fabian.knit...@lettink.de>wrote:
gc_arena instances are used by explicitly passing a pointer to it. So, > unless one of the functions takes an instance of gc_arena as a > parameter, you don't need to prepare one. As many functions in OpenVPN > take one, there's some dead code scattered about that needlessly > creates and frees gc arenas (probably because uses have come and gone > over time). So you can drop gc because it's not used. > > The argv family of functions apparently has its own memory management > and therefore argv_new() should be paired with an argv_reset(). > Otherwise the memory allocated by argv_printf() is leaked. > Thanks, Fabian. If I don't hear about anything else in the next couple of days I'll resubmit with these fixes. Regards, Jon
