On Thu, May 10, 2012 at 12:48 PM, David Sommerseth <openvpn.l...@topphemmelig.net> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 10/05/12 09:28, Adriaan de Jong wrote: >> I still prefer using the management interface. It keeps the >> interface to the Java stuff very clean (socket-based). Further you >> potentially allow other systems, such as Apple or Windows Phone to >> do the same. It avoids messy JNI stuff, and fits into the spirit of >> the management interface. It's the simplest solution. > > I agree. The plug-in approach seems a bit overkill to me. The > approach using the management API makes it far simpler.
It can be either management interface or socket between UI and plugin. The issue is monolithic vs modular. OpenVPN is already exploded in feature that are needed by specific installations. For every new feature was need to add we should ask our-selves if it can be added using modular approach and what is missing in the public interfaces in order to do the task. Of course adding features as #ifdefs is simpler at first, but later on they tend to be complex to maintain and untested, moving to modular components can delegate the maintenance and making the core product quality higher. If we need to allow directing custom commands to specific plugin via the management - this I can understand. But patching the core for these tasks is something I think we should avoid. Alon.
