Yes, that seems to be correct. Sorry!
Joachim
-----Original Message-----
From: David Sommerseth [mailto:[email protected]]
Sent: dinsdag 20 november 2012 10:19
To: Joachim Schipper
Cc: [email protected]; Adriaan de Jong
Subject: Re: [Openvpn-devel] [PATCH] Fix --show-pkcs11-ids
On 14/11/12 10:03, Adriaan de Jong wrote:
> [PATCH] Fix --show-pkcs11-ids (Bug #239)
>
> Broken by 75b49e406430299b187964744f82e50a9035a0d3.
>
> Signed-off-by: Joachim Schipper <[email protected]>
> ---
> src/openvpn/pkcs11.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Hi Joachim,
Thanks a lot for you fix! Just a little question. You mention this commit as
being the offending commit:
commit 75b49e406430299b187964744f82e50a9035a0d3
Author: Alon Bar-Lev <[email protected]>
List-Post: [email protected]
Date: Sun Apr 1 16:46:28 2012 +0300
cleanup: gc usage
Cleanup of "Use the garbage collector when retrieving x509 fields"
patch series.
Discussed at [1].
There should be an effort to produce common function prologue
and epilogue, so that cleanups will be done at single point.
[1] http://comments.gmane.org/gmane.network.openvpn.devel/5401
Signed-off-by: Alon Bar-Lev <[email protected]>
Acked-by: Adriaan de Jong <[email protected]>
Signed-off-by: David Sommerseth <[email protected]>
I'm just wondering how this could be related to you fix. As I see it, the
syntax of the if() statement you change didn't change, neither the behaviour of
pkcs11_certificate_dn().
I see that commit 00b973f8af85c3ea8fa3cef80eec55e8dc139b27 changes the
behaviour of pkcs11_certificate_dn() in both the OpenSSL and PolarSSL
implementation. So I'm suspecting you referenced the wrong commit. Right?
--
kind regards,
David Sommerseth
