ACK.
This is a bit bigger than "just move to new file" because it gets rid
of global variables at the same time (h_EngineHandle etc.) and simplifies
the error handling by introducing a CHECK_ERROR() macro - but as far as
I could figure out, it's still doing the same things.
I have not actually tested it, just "stare at code" - Samuli's buildbot
will make us a new installer based on this, and people using block_dns
functionality should thoroughly test it, with and without the iservice
running (iservice patch next).
As discussed on the list, I've added <winsock2.h> and <ws2ipdef.h> to
block_dns.c
Your patch has been applied to the master branch.
commit 6a33a34dee8f3b574275d8df1635fb550ec054f3
Author: Selva Nair
List-Post: openvpn-devel@lists.sourceforge.net
Date: Thu Feb 25 22:24:50 2016 -0500
Refactor and move the block-outside-dns code to a new file (block_dns.[ch])
Signed-off-by: Selva Nair <selva.n...@gmail.com>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <1456457091-3872-1-git-send-email-selva.n...@gmail.com>
URL: http://article.gmane.org/gmane.network.openvpn.devel/11264
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
