ACK. The OpenVPN changes are fairly straightforward and fully in-line with the other service-using modules. Same for the iservice changes - look reasonable and are fully in-line with the the other function calls.
Again, I did not test, just stared at the code and did a test compile (mingw 32bit on ubuntu 14.04) which worked. Your patch has been applied to the master branch. commit 2282b1be7968ef44accde705ccc64addab6d77ba Author: Selva Nair List-Post: [email protected] Date: Thu Feb 25 22:24:51 2016 -0500 Add support for block-outside-dns through the interactive service Signed-off-by: Selva Nair <[email protected]> Acked-by: Gert Doering <[email protected]> Message-Id: <[email protected]> URL: http://article.gmane.org/gmane.network.openvpn.devel/11265 Signed-off-by: Gert Doering <[email protected]> -- kind regards, Gert Doering
