Hi, On 13/07/17 14:59, Gert Doering wrote: > Hi, > > On Thu, Jul 13, 2017 at 09:16:13AM +0300, Samuli Seppänen wrote: >> There were no bugs reports about --disable-multi in Trac. I say scrap >> that option altogether and make the code slightly cleaner and less >> entangled. > > I tend to agree with you here. There are way too many #ifdef in our > code, and while Antonio's patch is technically fine, it adds more #ifdef > for a variant that nobody seems to be using - so that's not the way > to go.
I just went over this again and unfortunately I realized that, even though we can get rid of the --disable-multi switch (for which I will send a patch in a minute), we can't get rid of the various "#if P2MP" because its value depends on ENABLE_CRYPTO, which can still be enabled or disabled. Therefore, we have to keep the P2MP define as long we keep the ENABLE_CRYPTO logic. Cheers, > > P2MP_SERVER seems to have some uses, to be able to compile a client-only > binary for really small systems. So I'd keep that one, plus the associated > configure options. > > gert > > > > ------------------------------------------------------------------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > > > > _______________________________________________ > Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel > -- Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
