On 16/08/17 15:05, Antonio Quartulli wrote: > Hi, > > On 13/07/17 14:59, Gert Doering wrote: >> Hi, >> >> On Thu, Jul 13, 2017 at 09:16:13AM +0300, Samuli Seppänen wrote: >>> There were no bugs reports about --disable-multi in Trac. I say scrap >>> that option altogether and make the code slightly cleaner and less >>> entangled. >> >> I tend to agree with you here. There are way too many #ifdef in our >> code, and while Antonio's patch is technically fine, it adds more #ifdef >> for a variant that nobody seems to be using - so that's not the way >> to go. > > I just went over this again and unfortunately I realized that, even > though we can get rid of the --disable-multi switch (for which I will > send a patch in a minute), we can't get rid of the various "#if P2MP" > because its value depends on ENABLE_CRYPTO, which can still be enabled > or disabled. > > Therefore, we have to keep the P2MP define as long we keep the > ENABLE_CRYPTO logic.
I'm leaning towards removing both ENABLE_CRYPTO and P2MP. However, we need to update the buildslave configs too before doing that ... otherwise quite a few of us will drown in failure reports for a while. I have also pondered if there is any use cases for keeping them around. The only one I can imagine now is debugging, to see if something broke due to crypto or not. I honestly don't see the benefit of building OpenVPN in 2017 without crypto support for production environments (but I may just lack imagination; our users never cease to amaze me). But in the end, we have way too many #ifdefs around and many of them are entangled into each other, so for me the vote for code clarity trumps fine grained debugging in this case. And this #ifdef entanglement does not come without a maintenance cost as well. -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
