Hi, On 02-04-18 16:58, Selva Nair wrote: > On Mon, Apr 2, 2018 at 8:37 AM, Steffan Karger <stef...@karger.me> wrote: >> Also, this looks like a somewhat unrelated fix. I would have personally >> preferred it in a separate patch (so we can e.g. backport it easily even >> if we decide not not backport the functional change). > > The original did the search based on subject and hash separately, > which is now combined into a loop below this parsing chunk. So a > return, in place of break, is required here. The warning on parse error > is new (instead of silently returning NULL). But the end result of that > is still a FATAL error later in the code, as before. > > I'm ok to leave out the warning from this patch, though..
Ah, ok. If it's not independent, let's just keep it in this patch. -Steffan ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
