Hi, > (I *have* glanced over the code to see that there isn't anything that > looks "suspicious" - and of course it does not modify openvpn code, so > there is no risk for introducing remote exploits, crypto breaches, etc.) > > I found a few things I'd like to see cleaned up eventually...
Thank you. I am reviewing your suggestions and preparing patches for them. Stay tuned. > Then, it would be nice if file headers had a short comment "what is this > doing" (like, I just read through "msiex.c", and having an idea what I > can find in there makes life easier). > > Does some other patch in the series have an "overall picture" document > that explains how the "large picture" in MSI custom DLL works? Like, > first happens <this>, than <that>, and for a silent installer <there> > will be a change? Maybe just a pointer to a MS document? Good idea. I have put this on my TODO list. I still owe you "Administrators Guide for OpenVPN MSI Deployment". This would make a second document: "Developers Guide to OpenVPN MSI Setup". I should have done the later first, to make the code review easier for you, sorry. I have so much to explain you and so little time. :( IIRC, we agreed, I prepare documentation at OpenVPN Wiki. After it's published, remind me to URL it in the source code. > I have test-run the mingw-compilede tapctl on Win10, and "tapctl list" > "did something" (= it did not crash or complain about missing DLLs) - > but > it did not actually *work*. The machine has no TAP interfaces, just one > LAN card - and "tapctl list" prints out 2 or 10 different "LAN" adapters > (see attached image). Not sure this is how it should be... after I > installed OpenVPN & had it create a TAP interface, I still have 9 times > "LAN-Verbindung" but I also get an "Ethernet 2" now (which is correct). "tapctl list" lists all NICs found. Including the non-TAP ones. On my computer it shows 12, where I see only 2 in the Network Connections window. That's normal, as Windows have separate NICs for RAS: WAN, WAN IPv6, PPPoE, PPTP, L2TP, GRE, SSTP, etc. They all have silly names like "Local Area Connection* <n>" (note the asterisk in their name). They don't display elsewhere normally. Don't delete them with "tapctl delete" - like the "list" command lists _all_ interfaces, the "delete" can delete _any_ interface on your computer. Even with no TAP-Windows6 driver installed. On the other hand: "tapctl create" supports creating a TAP-Windows6 interface only. Shall I limit the "tapctl list" and "tapctl delete" commands to the TAP-Windows6 interfaces too? The utility is called *tap*ctl after all. Best regards, Simon
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
