Acked-by: Gert Doering <g...@greenie.muc.de>
The code looks good, and the local test for the "pull" case works,
unsurprisingly (as it does the very same things in that case). It might
trigger different behaviour for the "non pull" case - but then, it puts
everything back to where it was before (if saved), so I do not expect
surprises. Client side testing and "break the things we know are
broken on save/restore today" (compress etc) works as expected.
This is a (fairly light) refactoring patch, but as it is prerequisite for
two further patches (and maybe more) that are actual bugfixes, I considered
putting into 2.5 as well. It does not want to go in (#ifdef P2MP, and
conflicts with the NCP saving patch), so I'll backport the "compress"
and "route-*gateway" patch manually. Those are trivial enough.
Your patch has been applied to the master branch.
commit c1150e5b95b63a95ee4f157d8870d3214099d8a0
Author: Arne Schwabe
Date: Thu Apr 8 14:00:27 2021 +0200
Always save/restore pull options
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20210408120029.19438-1-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22079.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
