Acked-by: Gert Doering <[email protected]>
Stared-at-code (looks good), client side tested with the usual parcours
(good), and also tested with my two known-weird/broken test cases
for "compress not restored" (fixed!).
Your patch has been applied to the master branch.
I tried to apply it to release/2.5, but the resulting binary did not
behave - I can see that it restored the comp settings, but it does so
*after* OCC handshake (so the OCC warning is still there) *and* it does
not re-init compression - so the case "config has comp-lzo, server A
pushes compress lz4, server B pushes nothing" (so it should do LZO)
still fails. I think I need one of the other patches that changes
the "when are options saved/restored" as prerequisite here.
Will come back...
commit 2a414c3c79bba089183a517a2d355b5aaae0b4a4 (master)
Author: Arne Schwabe
Date: Thu Apr 8 14:00:28 2021 +0200
Also restore/save compress related options in reconnects
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Gert Doering <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg22078.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
