Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/506?usp=email )
Change subject: Implement support for AEAD tag at the end ...................................................................... Patch Set 3: (5 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/506/comment/008126a3_c9aca210 : PS2, Line 8: > Maybe some motivation? Done http://gerrit.openvpn.net/c/openvpn/+/506/comment/529bb2f4_83e37dd3 : PS2, Line 9: Change-Id: I00821d75342daf3f813b829812d648fe298bea81 > Missing sign-off Done File src/openvpn/ssl.h: http://gerrit.openvpn.net/c/openvpn/+/506/comment/42ec6996_93fc2b0d : PS2, Line 110: /** Suport for the AEAD tag at the end a larger peer id and IV */ > "a" -> "and" Done http://gerrit.openvpn.net/c/openvpn/+/506/comment/c4efc0b2_472126be : PS2, Line 111: #define IV_PROTO_DATA_V3 (1<<10) > This define seems unused in the current patch? Done File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/506/comment/cd150f1a_9bbdf41a : PS2, Line 269: /* This adds a few more methods that strictly necessary but this allows > "that" -> "than"? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/506?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I00821d75342daf3f813b829812d648fe298bea81 Gerrit-Change-Number: 506 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Fri, 09 Feb 2024 14:59:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
