Attention is currently required from: stipa, syzzer.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/506?usp=email )

Change subject: Implement support for AEAD tag at the end
......................................................................


Patch Set 6:

(1 comment)

File tests/unit_tests/openvpn/test_ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/506/comment/4842594f_fb4b5116 :
PS6, Line 268: /* This adds a few more methods than strictly necessary but this 
allows
> "that strictly necessary" or "that are not strictly necessary" ?
I think "than strictly necessary" is fine as it is. If you simplify the 
sentence by removing the adverbial terms it becomes: This adds more methods 
than necessary.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/506?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I00821d75342daf3f813b829812d648fe298bea81
Gerrit-Change-Number: 506
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: syzzer <stef...@karger.me>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: syzzer <stef...@karger.me>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Wed, 31 Jul 2024 13:09:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: stipa <lstipa...@gmail.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to