Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email )
Change subject: Route: add support for user defined routing table ...................................................................... Patch Set 2: (5 comments) File doc/man-sections/vpn-network-options.rst: http://gerrit.openvpn.net/c/openvpn/+/524/comment/8ef327d5_482e958e : PS1, Line 407: default taken from ``--route-table`` if set, otherwise :code:`0`. > Please change tab to spaces Done http://gerrit.openvpn.net/c/openvpn/+/524/comment/9c8be01e_92c07a0f : PS1, Line 408: > Should document that table-id can't be pushed. Done http://gerrit.openvpn.net/c/openvpn/+/524/comment/2891fff7_f030a0a0 : PS1, Line 464: > might be a good opportunity to make the description of --route-ipv6 more > consistent with --route? Cu […] Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/524/comment/0ca031f1_18cfb87a : PS1, Line 205: "--route-table [table_id] : Specify a custom routing table for use with --route(-ipv6).\n" > table_id is not optional, so don't use brackets here Done http://gerrit.openvpn.net/c/openvpn/+/524/comment/e912ffc8_22f4e21d : PS1, Line 6992: msg(M_WARN, "NOTE: --route-table specified, but not supported on this platform"); > Sounds good to me. Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7 Gerrit-Change-Number: 524 Gerrit-PatchSet: 2 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 20 Feb 2024 13:58:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: its_Giaan <gianma...@mandelbit.com> Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
