Attention is currently required from: its_Giaan, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/524?usp=email )
Change subject: Route: add support for user defined routing table ...................................................................... Patch Set 3: Code-Review-1 (7 comments) File doc/man-sections/vpn-network-options.rst: http://gerrit.openvpn.net/c/openvpn/+/524/comment/29fafc4d_019065e1 : PS3, Line 374: a user defined routing table can be used instead. "an user" http://gerrit.openvpn.net/c/openvpn/+/524/comment/cfaf208a_43bb3e07 : PS3, Line 407: Since this option must be an entirely local choice, won't be pushable. Time seems weird to me, would change to "it isn't pushable" http://gerrit.openvpn.net/c/openvpn/+/524/comment/c5dce9cb_c194c9e8 : PS3, Line 408: default taken from ``--route-table`` if set, otherwise :code:`0`. please change tab to space http://gerrit.openvpn.net/c/openvpn/+/524/comment/186800fb_289c2ebc : PS3, Line 461: route-ipv6 ipv6addr/bits [gateway] when listing all possible choices, you can leave off the "[" optional markers http://gerrit.openvpn.net/c/openvpn/+/524/comment/dc32db5a_b03f8605 : PS3, Line 464: trailing whitespace http://gerrit.openvpn.net/c/openvpn/+/524/comment/c7665500_392297ff : PS3, Line 475: default taken from ``--route-table`` if set, otherwise :code:`0`. same comments apply here as for --route (tab, won't->it isn't) File src/openvpn/route.h: http://gerrit.openvpn.net/c/openvpn/+/524/comment/f42523ea_da5a7db8 : PS3, Line 98: spurious whitespace? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7 Gerrit-Change-Number: 524 Gerrit-PatchSet: 3 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Comment-Date: Tue, 12 Mar 2024 17:11:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
