Attention is currently required from: flichtenheld, plaisthos, selvanair. ssbssa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/621?usp=email )
Change subject: Implement Windows CA template match for Crypto-API selector ...................................................................... Patch Set 2: (6 comments) Patchset: PS2: The new patch should resolve all comments. File doc/man-sections/windows-options.rst: http://gerrit.openvpn.net/c/openvpn/+/621/comment/dea7be4c_cb1afe99 : PS1, Line 62: cryptoapicert "TMPL:1.3.6.1.4..." > Add an example where the template name is used instead of OID? Done File src/openvpn/cryptoapi.c: http://gerrit.openvpn.net/c/openvpn/+/621/comment/63f95189_515a1777 : PS1, Line 217: } > I think I said this in response to the original in 2021 as well: why separate > into two calls like th […] Done http://gerrit.openvpn.net/c/openvpn/+/621/comment/404e038e_7d02372b : PS1, Line 220: if (!info && fallback && groupid) > I see the only place this is called is with fallback=true, so we do not need > that argument and can a […] Done http://gerrit.openvpn.net/c/openvpn/+/621/comment/f5b1a275_d56ff8fa : PS1, Line 277: * TMPL:<template name> > template name or OID ? Done http://gerrit.openvpn.net/c/openvpn/+/621/comment/79d659be_2fe54731 : PS1, Line 314: find_type = CERT_FIND_ANY; > Shouldn't we use a more restrictive search with, say, > CERT_FIND_HAS_PRIVATE_KEY? If there are multip […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/621?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia2c3e4c5c83ecccce1618c43b489dbe811de5351 Gerrit-Change-Number: 621 Gerrit-PatchSet: 2 Gerrit-Owner: ssbssa <ssb...@yahoo.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: selvanair <selva.n...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: selvanair <selva.n...@gmail.com> Gerrit-Comment-Date: Mon, 03 Jun 2024 14:35:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: selvanair <selva.n...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
