Attention is currently required from: flichtenheld, plaisthos, ssbssa. selvanair has posted comments on this change by ssbssa. ( http://gerrit.openvpn.net/c/openvpn/+/621?usp=email )
Change subject: Implement Windows CA template match for Crypto-API selector ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS2: Thanks for the changes. Looks good to me now. I have no setup to test this but I did confirm that "TMPL:" is recognized as a valid selector, and the code does iterate through certificates with private keys present. Acked-by: Selva Nair <selva.n...@gmail.com> File src/openvpn/cryptoapi.c: http://gerrit.openvpn.net/c/openvpn/+/621/comment/66b4877b_503018f8?usp=email : PS1, Line 220: if (!info && fallback && groupid) > Done nitpick: the comment is now a bit inaccurate -- "and fallback requested" is no longer required. May be edited at merge time. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/621?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia2c3e4c5c83ecccce1618c43b489dbe811de5351 Gerrit-Change-Number: 621 Gerrit-PatchSet: 2 Gerrit-Owner: ssbssa <ssb...@yahoo.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: selvanair <selva.n...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ssbssa <ssb...@yahoo.de> Gerrit-Comment-Date: Thu, 06 Jun 2024 04:50:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: ssbssa <ssb...@yahoo.de> Comment-In-Reply-To: selvanair <selva.n...@gmail.com>
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
