Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1108?usp=email
to review the following change.
Change subject: forward: Make sure pip flags are treated as unsigned
......................................................................
forward: Make sure pip flags are treated as unsigned
process_ip_header already expects them to be unsigned,
make sure the flags are to avoid spurious conversion warnings.
Change-Id: I6d42c67b8dc5512933bed482bd9c2be80c63e993
Signed-off-by: Frank Lichtenheld <[email protected]>
---
M src/openvpn/forward.h
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/08/1108/1
diff --git a/src/openvpn/forward.h b/src/openvpn/forward.h
index 2818fd1..b3e424c 100644
--- a/src/openvpn/forward.h
+++ b/src/openvpn/forward.h
@@ -318,13 +318,13 @@
*/
void reschedule_multi_process(struct context *c);
-#define PIPV4_PASSTOS (1<<0)
-#define PIP_MSSFIX (1<<1) /* v4 and v6 */
-#define PIP_OUTGOING (1<<2)
-#define PIPV4_EXTRACT_DHCP_ROUTER (1<<3)
-#define PIPV4_CLIENT_NAT (1<<4)
-#define PIPV6_ICMP_NOHOST_CLIENT (1<<5)
-#define PIPV6_ICMP_NOHOST_SERVER (1<<6)
+#define PIPV4_PASSTOS (1u<<0)
+#define PIP_MSSFIX (1u<<1) /* v4 and v6 */
+#define PIP_OUTGOING (1u<<2)
+#define PIPV4_EXTRACT_DHCP_ROUTER (1u<<3)
+#define PIPV4_CLIENT_NAT (1u<<4)
+#define PIPV6_ICMP_NOHOST_CLIENT (1u<<5)
+#define PIPV6_ICMP_NOHOST_SERVER (1u<<6)
void process_ip_header(struct context *c, unsigned int flags, struct buffer
*buf,
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1108?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6d42c67b8dc5512933bed482bd9c2be80c63e993
Gerrit-Change-Number: 1108
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
