Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email )
Change subject: Allow route_ipv6_match_host to be used outside of route.c ...................................................................... Patch Set 3: Code-Review+1 (4 comments) Patchset: PS3: patch looks good to me, but I have a few nitpicks in line with Heiko's opinion. File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/1191/comment/c97633f9_e67e2e01 : PS1, Line 719: route_ipv6_match_host(const struct in6_addr *network, unsigned int bits, const struct in6_addr *host) > The name is somewhat outdated with the new signature of the function. […] I agree - that also makes it obvious that there is no route involved anymore http://gerrit.openvpn.net/c/openvpn/+/1191/comment/128cf6ac_eb198fb9 : PS1, Line 726: int i = 0; > No i is used outside the loop in line 740/742 Heiko said there is no need to "initialize" i. So just drop "= 0" as it's initialized by the for loop. File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/1191/comment/336ca137_8e3a6ff8 : PS3, Line 716: /* (not the most beautiful implementation in the world, but portable and maybe drop opening and closing parenthesis? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ief1495b52ea81cac35d78e40264372d3869423f1 Gerrit-Change-Number: 1191 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <anto...@mandelbit.com> Gerrit-CC: d12fk <he...@openvpn.net> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 16 Sep 2025 21:03:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: plaisthos <arne-open...@rfc2549.org> Comment-In-Reply-To: d12fk <he...@openvpn.net> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
