Attention is currently required from: d12fk, flichtenheld.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email )

Change subject: Allow route_ipv6_match_host to be used outside of route.c
......................................................................


Patch Set 2:

(2 comments)

File src/openvpn/route.c:

http://gerrit.openvpn.net/c/openvpn/+/1191/comment/2f55ee96_d20f3430 :
PS1, Line 726:     int i = 0;
> Don't have to initialize i as it is done in the loop.
No i is used outside the loop in line 740/742


http://gerrit.openvpn.net/c/openvpn/+/1191/comment/5e5c6e75_616c359f :
PS1, Line 740:     unsigned mask = 0xff << (8 - bits);
> any particular reason you left the "int" off here but used in the other 
> places?
no. Will fix it.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1191?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ief1495b52ea81cac35d78e40264372d3869423f1
Gerrit-Change-Number: 1191
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: d12fk <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: d12fk <[email protected]>
Gerrit-Comment-Date: Tue, 16 Sep 2025 14:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
Comment-In-Reply-To: d12fk <[email protected]>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to