Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1251?usp=email )
Change subject: sitnl: Clean up type handling ...................................................................... Patch Set 3: (1 comment) File src/openvpn/networking_sitnl.c: http://gerrit.openvpn.net/c/openvpn/+/1251/comment/586c07ec_1e0e87a3?usp=email : PS3, Line 150: rta->rta_len = (unsigned short)len; what happens if we rather make everything unsigned short instead of passing through size_t? (technically speaking here we could have a value that is larger than USHRT_MAX, because len and maxlen are size_t) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1251?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I20205ebd06bbf7cbee8c9be93f399961f5b74fcc Gerrit-Change-Number: 1251 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Mon, 06 Oct 2025 19:51:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
