Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1251?usp=email )
Change subject: sitnl: Clean up type handling ...................................................................... Patch Set 3: (1 comment) File src/openvpn/networking_sitnl.c: http://gerrit.openvpn.net/c/openvpn/+/1251/comment/f96e2ed5_3791b0fb?usp=email : PS3, Line 150: rta->rta_len = (unsigned short)len; > what happens if we rather make everything unsigned short instead of passing > through size_t? […] I still think it is better to use size_t for the arguments. We often use sizeof for these arguments so some compiler might throw warnings at us. Better to make the cast here later. But yes, we should add an assert here like in the other places. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1251?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I20205ebd06bbf7cbee8c9be93f399961f5b74fcc Gerrit-Change-Number: 1251 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: ordex <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Tue, 07 Oct 2025 10:52:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ordex <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
