Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by flichtenheld. ( 
http://gerrit.openvpn.net/c/openvpn/+/1207?usp=email )

Change subject: Enable -Wtype-limits by default (via -Wextra)
......................................................................


Patch Set 4:

(1 comment)

File src/openvpn/init.c:

http://gerrit.openvpn.net/c/openvpn/+/1207/comment/2c9249b3_2d7cd62b?usp=email :
PS3, Line 2732:     bool datav2_enabled = c->options.peer_id < MAX_PEER_ID;
> Yes that is correct from the standpoint of no sign compare but the check 
> should be fixed to actually […]
https://gerrit.openvpn.net/c/openvpn/+/1273



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1207?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Iaabddb6f81cd94863291b193aae9d384a8f9d871
Gerrit-Change-Number: 1207
Gerrit-PatchSet: 4
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Tue, 14 Oct 2025 11:35:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to