Attention is currently required from: MaxF, plaisthos. syzzer has posted comments on this change by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1441?usp=email )
Change subject: Add support for Mbed TLS 4 ...................................................................... Patch Set 3: (5 comments) Patchset: PS3: A few initials thoughts when glazing over part of the code. File src/openvpn/crypto_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/1441/comment/ddbc1422_631be2a6?usp=email : PS3, Line 88: /* TODO: Complete the table. */ Consider copying the table from the private mbedtls header file, might save you some work. And complain with mbedtls that they broke a useful API... http://gerrit.openvpn.net/c/openvpn/+/1441/comment/35ed3edf_fa15f561?usp=email : PS3, Line 204: return (int)cipher_info->key_bytes; key_bytes is already int, right? http://gerrit.openvpn.net/c/openvpn/+/1441/comment/eaf36ed8_1b9ab022?usp=email : PS3, Line 292: ALLOC_OBJ_CLEAR(ctx, cipher_ctx_t); Good catch, adding the _CLEAR. http://gerrit.openvpn.net/c/openvpn/+/1441/comment/b63901cc_f7bfd9e1?usp=email : PS3, Line 299: /* TODO: Log warning on errors? */ We can't handle the error here. If this errors out, looks to me like we are in an invalid state. Consider ASSERT()'in out if it fails. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1441?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111bcc627cdb0fae Gerrit-Change-Number: 1441 Gerrit-PatchSet: 3 Gerrit-Owner: MaxF <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: syzzer <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: MaxF <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 16:00:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
