Attention is currently required from: plaisthos, syzzer. MaxF has posted comments on this change by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/1441?usp=email )
Change subject: Add support for Mbed TLS 4 ...................................................................... Patch Set 3: (3 comments) File src/openvpn/crypto_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/1441/comment/31ee5c24_5c1a094c?usp=email : PS3, Line 88: /* TODO: Complete the table. */ > Consider copying the table from the private mbedtls header file, might save > you some work. […] I looked at it and I'm not sure how much it helps. The new PSA_KEY_TYPE and PSA_ALG magic numbers don't seem to be in that table. I also don't know if legacy crypto defines like MBEDTLS_AES_C are externally visible. http://gerrit.openvpn.net/c/openvpn/+/1441/comment/26d91568_0d8c32b2?usp=email : PS3, Line 204: return (int)cipher_info->key_bytes; > key_bytes is already int, right? Right http://gerrit.openvpn.net/c/openvpn/+/1441/comment/50b21610_ae2e0509?usp=email : PS3, Line 299: /* TODO: Log warning on errors? */ > We can't handle the error here. If this errors out, looks to me like we are > in an invalid state. […] I added ASSERTs to this and similar functions. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1441?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111bcc627cdb0fae Gerrit-Change-Number: 1441 Gerrit-PatchSet: 3 Gerrit-Owner: MaxF <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-CC: syzzer <[email protected]> Gerrit-Attention: syzzer <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 16:42:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: syzzer <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
