Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1457?usp=email )
Change subject: openvpnserv: Fix conversion warnings in interactive.c ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: Two comments, and I really think Heiko should have a look at these changes. File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/1457/comment/55b31c70_6a63bb5f?usp=email : PS3, Line 1391: RegWStringLength(PCWSTR string) I'd suggest to name that `RegWStringSize()` - d12fk has tried to make everything that is a "number of bytes in memory" named "xxxsize", and everything that is "length of glyphs in a whatever-string" a "xxxlength". So this would be a "size" function. (Also for `length` inside the function, as soon as `wcslen()` is multiplied it's not longer a "length" in that terminology) http://gerrit.openvpn.net/c/openvpn/+/1457/comment/6dd9276d_710aa1d2?usp=email : PS3, Line 1744: static LSTATUS why is that change? We have a `DWORD err` and return that? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1457?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I864cd4a718886f437b72e93d0286f90fcb73592b Gerrit-Change-Number: 1457 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 08 Jan 2026 17:27:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
