Attention is currently required from: cron2, d12fk, plaisthos. flichtenheld has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1457?usp=email )
Change subject: openvpnserv: Fix conversion warnings in interactive.c ...................................................................... Patch Set 4: (2 comments) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/1457/comment/cb480e29_6a268e34?usp=email : PS3, Line 1391: RegWStringLength(PCWSTR string) > I'd suggest to name that `RegWStringSize()` - d12fk has tried to make > everything that is a "number o […] Done http://gerrit.openvpn.net/c/openvpn/+/1457/comment/591009df_dff70458?usp=email : PS3, Line 1744: static LSTATUS > why is that change? We have a `DWORD err` and return that? Yeah, I started cleaning up DWORD vs LSTATUS. But didn't really finish it. Also not relevant right now since they are the same size, only differ in signedness. So removing all these changes and deferring them to later. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1457?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I864cd4a718886f437b72e93d0286f90fcb73592b Gerrit-Change-Number: 1457 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld <[email protected]> Gerrit-Reviewer: cron2 <[email protected]> Gerrit-Reviewer: d12fk <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Fri, 09 Jan 2026 12:56:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
