Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1477?usp=email )
Change subject: Merge stream_buf_get_next and stream_buf_set_next ...................................................................... Patch Set 3: (6 comments) File src/openvpn/socket.h: http://gerrit.openvpn.net/c/openvpn/+/1477/comment/f7398ccd_99a35101?usp=email : PS3, Line 552: * required and other false. (full packet is ready) > "otherwise"? Done File src/openvpn/socket.c: http://gerrit.openvpn.net/c/openvpn/+/1477/comment/39240118_2bfb6057?usp=email : PS3, Line 2067: * resets the stream buffer to be setup for the next round of > "set up" Done http://gerrit.openvpn.net/c/openvpn/+/1477/comment/40e9a444_87973fac?usp=email : PS3, Line 2122: * Sets the parameter buf to the current buffer of sb->buf. > superfluous whitespace in the middle of the sentence Done http://gerrit.openvpn.net/c/openvpn/+/1477/comment/a122986d_eed4a789?usp=email : PS3, Line 2154: * move anything in sb->buf beyond a full beyond packet to sb->residual > Remove second "beyond" Done http://gerrit.openvpn.net/c/openvpn/+/1477/comment/3f3c7b97_17270177?usp=email : PS3, Line 2160: * If a packet is outside of the allowed range is detected, the error state > Remove first "is" Done http://gerrit.openvpn.net/c/openvpn/+/1477/comment/ee70cc87_34f67587?usp=email : PS3, Line 2164: * @param length_added The length that has been added to sb->buf > Would be good to add a little more information here. I see this can be 0. […] Added a paragraph for that. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1477?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifd3e953104a67c8bf2a225e179865e3dbd0dbfbc Gerrit-Change-Number: 1477 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 22 Jan 2026 09:10:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
