Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1477?usp=email )

Change subject: Merge stream_buf_get_next and stream_buf_set_next
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

Patchset:

PS4:
You didn't fix the comments in the commit message.


File src/openvpn/socket.c:

http://gerrit.openvpn.net/c/openvpn/+/1477/comment/015184f8_a171efb7?usp=email :
PS3, Line 2070:  * But still leaves the current packet in sb->buf to be 
potentially
> Will not report all individual occurrences but all instances of something 
> like this could use a `\c` […]
Done


http://gerrit.openvpn.net/c/openvpn/+/1477/comment/e279cd9f_40cac0d3?usp=email :
PS3, Line 2164:  * @param length_added The length that has been added to sb->buf
> Added a paragraph for that.
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1477?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ifd3e953104a67c8bf2a225e179865e3dbd0dbfbc
Gerrit-Change-Number: 1477
Gerrit-PatchSet: 4
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Thu, 22 Jan 2026 12:05:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <[email protected]>
Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to