Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1828?usp=email )

Change subject: Move schedule test to a unit test
......................................................................


Patch Set 2:

(3 comments)

Patchset:

PS1:
> why did you decide to include this test in test_misc instead of creating its 
> own runner? You did cre […]
I don't think we need more test runners. We already have a quite a lot. But I 
still wanted to have it in its own C file to seperate the code.


File tests/unit_tests/openvpn/Makefile.am:

http://gerrit.openvpn.net/c/openvpn/+/1828/comment/480750f8_e68355c4?usp=email :
PS1, Line 373:     test_schedule.c test_schedule.h \
> wrong whitespace
Done


File tests/unit_tests/openvpn/test_schedule.h:

http://gerrit.openvpn.net/c/openvpn/+/1828/comment/c822d468_63f4382d?usp=email :
PS1, Line 23:  *  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> old style header, please use current one
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1828?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie33aea26026e07c860da7d79880cef6b27b7b0e8
Gerrit-Change-Number: 1828
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Tue, 28 Jul 2026 12:16:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to