Attention is currently required from: plaisthos. flichtenheld has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1828?usp=email )
Change subject: Move schedule test to a unit test ...................................................................... Patch Set 4: Code-Review-1 (3 comments) File tests/unit_tests/openvpn/test_schedule.c: http://gerrit.openvpn.net/c/openvpn/+/1828/comment/6917016e_d4b4df7a?usp=email : PS4, Line 91: ASSERT(e != e->lt); We should change these to proper cmocka asserts, but not sure whether it is better to do that in a separate commit? http://gerrit.openvpn.net/c/openvpn/+/1828/comment/c1735282_e178d672?usp=email : PS4, Line 168: #else /* if 1 */ Does this code still have value? If so, then we should integrate it into the test. If not, maybe just delete it? http://gerrit.openvpn.net/c/openvpn/+/1828/comment/3ce2fabc_9e5f4fc4?usp=email : PS4, Line 173: struct gc_arena gc = gc_new(); gc seems to be unused? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1828?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie33aea26026e07c860da7d79880cef6b27b7b0e8 Gerrit-Change-Number: 1828 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Wed, 29 Jul 2026 12:01:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
