Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1571?usp=email )

The change is no longer submittable: Code-Review is unsatisfied now.

Change subject: Change hash iv to a be a fixed sized array
......................................................................


Patch Set 20: Code-Review-1

(2 comments)

File src/openvpn/mroute.c:

http://gerrit.openvpn.net/c/openvpn/+/1571/comment/400191c1_fbfefae1?usp=email :
PS20, Line 361:                      mroute_addr_hash_len((const struct 
mroute_addr *)key), *(int32_t *)hash_key);
Should be `uint32_t*`


File tests/unit_tests/openvpn/test_misc.c:

http://gerrit.openvpn.net/c/openvpn/+/1571/comment/29f53a5d_6b9aef7e?usp=email :
PS20, Line 135:     return hash_func((const uint8_t *)str, len, *(int32_t 
*)(hash_key));
Should be `uint32_t*`



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1571?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: If47c7d920b2fa4047b7db03fcde821899839324d
Gerrit-Change-Number: 1571
Gerrit-PatchSet: 20
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Thu, 30 Jul 2026 10:21:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to