Attention is currently required from: flichtenheld. plaisthos has posted comments on this change by plaisthos. ( http://gerrit.openvpn.net/c/openvpn/+/1571?usp=email )
Change subject: Change hash iv to a be a fixed sized array ...................................................................... Patch Set 20: (4 comments) File src/openvpn/list.c: http://gerrit.openvpn.net/c/openvpn/+/1571/comment/df7e5f88_b8113cd6?usp=email : PS19, Line 425: hash_func_new_ctx(void) > forgot to remove? yes. Removed File src/openvpn/mroute.c: http://gerrit.openvpn.net/c/openvpn/+/1571/comment/c129ac68_53fe4557?usp=email : PS20, Line 361: mroute_addr_hash_len((const struct mroute_addr *)key), *(int32_t *)hash_key); > Should be `uint32_t*` Done File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/1571/comment/f195ffaa_13f23ddc?usp=email : PS19, Line 313: * value and function for the context parameters. > comment is obsolete Done File tests/unit_tests/openvpn/test_misc.c: http://gerrit.openvpn.net/c/openvpn/+/1571/comment/37bb3b03_050c364d?usp=email : PS20, Line 135: return hash_func((const uint8_t *)str, len, *(int32_t *)(hash_key)); > Should be `uint32_t*` Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1571?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: If47c7d920b2fa4047b7db03fcde821899839324d Gerrit-Change-Number: 1571 Gerrit-PatchSet: 20 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 30 Jul 2026 16:01:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
