Attention is currently required from: plaisthos.

flichtenheld has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email )

Change subject: Replace SHA256 with SIPHASH24 in hamc cookie approach
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1827/comment/90b2076c_3146e3f2?usp=email :
PS1, Line 7: Replace SHA256 with SIPHASH24 in hamc cookie approach
"hmac"


File src/openvpn/ssl_pkt.c:

http://gerrit.openvpn.net/c/openvpn/+/1827/comment/fe92a7a8_f46cb7fb?usp=email :
PS1, Line 458:     /* ensure out input is large enough */
"our"


http://gerrit.openvpn.net/c/openvpn/+/1827/comment/60749da3_4d0ef657?usp=email :
PS1, Line 481:     /* add session id of client */
obsolete comment? or missing code?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3b6bb178ffb2bb49981bc23eabf04fe8e06d6fc3
Gerrit-Change-Number: 1827
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Comment-Date: Thu, 30 Jul 2026 10:35:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to