Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email )

Change subject: Replace SHA256 with SIPHASH24 in hamc cookie approach
......................................................................


Patch Set 1:

(3 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/1827/comment/02ddaf25_c1974c19?usp=email :
PS1, Line 7: Replace SHA256 with SIPHASH24 in hamc cookie approach
> "hmac"
Done


File src/openvpn/ssl_pkt.c:

http://gerrit.openvpn.net/c/openvpn/+/1827/comment/03e63c76_056f1882?usp=email :
PS1, Line 458:     /* ensure out input is large enough */
> "our"
Done


http://gerrit.openvpn.net/c/openvpn/+/1827/comment/321fe484_41c054de?usp=email :
PS1, Line 481:     /* add session id of client */
> obsolete comment? or missing code?
No. Actually I accidentially removed hasing the client sid. Thanks for noticing.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1827?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3b6bb178ffb2bb49981bc23eabf04fe8e06d6fc3
Gerrit-Change-Number: 1827
Gerrit-PatchSet: 1
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 30 Jul 2026 12:02:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to