Attention is currently required from: plaisthos, stipa. ralf_lici has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1752?usp=email )
Change subject: oob: Add --server-probe-reply to advertise probe reply values ...................................................................... Patch Set 24: Code-Review-1 (2 comments) File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1752/comment/ec68f1fa_f418543b?usp=email : PS24, Line 691: A UDP server : answers probes by default, whether or not this option is given IMHO this is a wrong design decision. The change is somewhat invasive for a server configuration and silently enabling it, with default values that cannot faithfully represent every deployment seems wrong. Specifically, upgraded servers reply and are therefore ranked ahead of older, nonresponding servers, even though the administrator configured no selection policy. Am I missing something? I would expect the server to answer only when `server_probe_reply_defined && !server_probe_reply_disabled`. File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1752/comment/5e28254e_3725cfae?usp=email : PS24, Line 131: && opcode_is_oob(*BPTR(&m->top.c2.buf) >> P_OPCODE_SHIFT)) `opcode_is_oob` identifies the generic OOB envelope, not a `SERVER_PROBE` specifically. Since the same opcode carries the other OOB message types, `--server-probe-reply off` will also disable `ECHO_REQ`, `ACC`, and any future OOB handling before the message can be parsed. Is disabling all OOB traffic intentional? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1752?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id74cfae7e9d69029d2ddbf635ee85a2a6cedc3d8 Gerrit-Change-Number: 1752 Gerrit-PatchSet: 24 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: ralf_lici <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: stipa <[email protected]> Gerrit-Comment-Date: Wed, 16 Sep 2026 15:45:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
