Attention is currently required from: plaisthos, ralf_lici. stipa has posted comments on this change by stipa. ( http://gerrit.openvpn.net/c/openvpn/+/1752?usp=email )
Change subject: oob: Add --server-probe-reply to advertise probe reply values ...................................................................... Patch Set 29: (5 comments) File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1752/comment/ae876caf_30795eec?usp=email : PS24, Line 671: server-probe-reply off > Since the goal was to allow eventually the server probe to be a better way of > three way handshake al […] No good reason, I added it just in case. A server doesn't answer only makes its own clients slower, and what an admin might wait is covered by the values (priority - "dont prefer me", connect_livetime - "no handshake handover". Removed off. File doc/man-sections/server-options.rst: http://gerrit.openvpn.net/c/openvpn/+/1752/comment/dadd641e_e771cdac?usp=email : PS28, Line 688: servers of the same priority proportionally to their weights. > Should mention if low number or high number of priority means better priority. "clients try servers with a lower priority value first" is already there, make it explicit "lower value = preferred, as in DNS SRV" http://gerrit.openvpn.net/c/openvpn/+/1752/comment/e2e0ae8e_26408188?usp=email : PS28, Line 701: > gets little what? changed to "while a replayed probe is answered at most that often" File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1752/comment/e17f2771_aedddbcb?usp=email : PS24, Line 259: .priority = (uint16_t)m->top.options.server_probe_reply_priority, > If only uint16 is the valid range, then the type should be uint16 and not > doing casting here. oob_probe_reply_{priority,weight,max_latency_diff} become uint16_t in options.h, casts are gone. File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1752/comment/c77c9465_3697676c?usp=email : PS28, Line 249: return false; /* --server-probe-reply off: exactly the probe reply, nothing else */ > I don't understand what "exactly the probe reply, nothing else" means here. "off" is gone now. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1752?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Id74cfae7e9d69029d2ddbf635ee85a2a6cedc3d8 Gerrit-Change-Number: 1752 Gerrit-PatchSet: 29 Gerrit-Owner: stipa <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: ralf_lici <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: ralf_lici <[email protected]> Gerrit-Comment-Date: Fri, 18 Sep 2026 08:33:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: plaisthos <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
