It is quite a while now and no-one responded. Any reasons not to commit it?
Thanks, Maarten On Mon, 2010-10-18 at 15:21 +0200, Maarten Bezemer wrote: > Anyone able to comment on the patch, whether it is good enough or some > things need to be changed before it can accepted? > > Thanks, > Maarten > > > On Wed, 2010-10-06 at 13:56 +0200, Maarten Bezemer wrote: > > For the 'Marvell Orion' target the iptables package does not compile. > > See forum topic: https://forum.openwrt.org/viewtopic.php?pid=117520 > > Maybe for other targets as well? > > > > In short: the problem is that /usr/lib/libc is used while linking > > instead of the cross-compiled version. > > > > I provided a patch for this problem, but I am unsure whether it is a > > correct fix or just an ugly hack. I did not check whether this patch is > > disturbing any of the other targets. > > But, with a clean checkout (with the default configuration, Broadcom > > BCM947xx/953xx) it builds fine. > > > > So could someone take a look at it and eventually provide feedback for > > improvements or tell that it is good as it is and it can be submitted? > > > > Thanks, > > Maarten > > _______________________________________________ > > openwrt-devel mailing list > > openwrt-devel@lists.openwrt.org > > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
