On 4 January 2013 21:52, Damian Kaczkowski <damian.kaczkow...@gmail.com>wrote:

> On 4 January 2013 18:25, Bastian Bittorf <bitt...@bluebottle.com> wrote:
>
>> - MKSWAP and SWAPONOFF has to be a dependency, the old package compcache
>>   does this via
>>
>>   DEPENDS:=@BUSYBOX_CONFIG_SWAPONOFF @BUSYBOX_CONFIG_MKSWAP
>>
>
> I think better dependency would be:
>
> define KernelPackage/zram/config
>   select BUSYBOX_CONFIG_MKSWAP if !PACKAGE_swap-utils
>   select BUSYBOX_CONFIG_SWAPONOFF if !PACKAGE_swap-utils
> endef
>


btw. Do we really need dependency for mkswap / swaponoff ? You can use any
fs on zram disk not only swap (also your init script already checks for
mkswap and swapon bins (but not swapoff btw.)). Maybe better would be what
hauke proposed? - just set CONFIG_BUSYBOX_CONFIG_MKSWAP=y,
CONFIG_BUSYBOX_CONFIG_SWAPONOFF=y as default config. Then also some other
packages might benefit from this, eg. block-mount
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to