On 03/10/2013 04:18 PM, Bastian Bittorf wrote: > * Daniel Golle <daniel.go...@gmail.com> [10.03.2013 15:17]: >> ;; >> + "430080"*) >> + iw reg set IL >> + model="TP-Link TL-WDR4300 (IL)" >> + ;; > > dont do 'iw reg' magic here, the user should decide > that in the common way (uci...)
Well, I agree :) However, the law over here says that it should not be up to the user to decide that. And if the importer implemented it properly (ie. setting the right values in the EEPROM), it also wouldn't allow the user the violate the law. Usually, it goes like this: ath9k interprets the EEPROM and sets the regdomain according to what it finds there and then crda will only allow the user to further limit herself by setting a countrycode in UCI or follow-up iw reg set or crda calls. The idea of doing iw reg set IL when the board is detected was to simulate that behaviour and achieve the same result as if it was done properly in the EEPROM (i.e. the user can then only further limit herself) An alternative to my current way of implementing it would be to handle it via ath9k_platform_data and detect the board in mach-*.c (and in the future pass that nasty little detail through DTS/OF) However, doing it in user-space is a one-liner (though I agree it's in the wrong place). Not implementing it at all would be irresponsible towards users imho. _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
